UtilityMethodTestCase: safeguard against duplicate test markers #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PR PHPCSStandards/PHP_CodeSniffer 777
Sister-PR to upstream PHPCSStandards/PHP_CodeSniffer 777 addressing issue PHPCSStandards/PHP_CodeSniffer 773. This commit adds a `testTestMarkersAreUnique()` test method to the `UtilityMethodTestCase` class to automatically verify that the case file in use by the child test class only contains unique test markers. The actual logic for the test is in a custom, `static`, assertion `assertTestMarkersAreUnique()` to allow for calling the assertion directly if an additional test case file is tokenized for the test. Includes unit tests. Includes updating a few tests related to the `UtilityMethodTestCase` itself to not run the `testTestMarkersAreUnique()` test when the test is testing an error condition/doesn't have a valid `$phpcsFile` property set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetMethodParametersTest: sync with upstream
See PR PHPCSStandards/PHP_CodeSniffer#777
UtilityMethodTestCase: safeguard against duplicate test markers
Sister-PR to upstream PHPCSStandards/PHP_CodeSniffer#777 addressing issue PHPCSStandards/PHP_CodeSniffer#773.
This commit adds a
testTestMarkersAreUnique()test method to theUtilityMethodTestCaseclass to automatically verify that the case file in use by the child test class only contains unique test markers.The actual logic for the test is in a custom,
static, assertionassertTestMarkersAreUnique()to allow for calling the assertion directly if an additional test case file is tokenized for the test.Includes unit tests.
Includes updating a few tests related to the
UtilityMethodTestCaseitself to not run thetestTestMarkersAreUnique()test when the test is testing an error condition/doesn't have a valid$phpcsFileproperty set.